This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python][rfc] Use attributes in gdb.Symtab andgdb.Symtab_and_line.


El vie, 05-12-2008 a las 16:08 -0700, Tom Tromey escribiÃ:
> >>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
> 
> Thiago> For gdb.Symtab, changed get_filename method to filename attribute, but
> Thiago> kept to_fullname as a method.
> Thiago> For gdb.Symtab_and_line, changed all methods to attributes. 
> 
> This one looks good to me.
> 
> About "to_fullname"... that seems like one of those names picked to
> mirror gdb internals.  But that "to" doesn't seem any more meaningful
> than "get" -- I'd prefer just "fullname".  What do you think?

Agreed. Committed with that change.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]