This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: [python] [rfc] StdBitsetPrinter patch for printing bitsets represented by a single unsigned long.
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: Project Archer <archer at sourceware dot org>
- Date: Mon, 23 Feb 2009 11:52:34 -0700
- Subject: Re: [python] [rfc] StdBitsetPrinter patch for printing bitsets represented by a single unsigned long.
- References: <49A2E89B.10607@redhat.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> 2009-02-23 Phil Muldoon <pmuldoon@redhat.com>
Phil> * python/lib/gdb/libstdcxx/v6/printers.py
Phil> (StdBitsetPrinter.children): Check "_M_w" for int type. If it is an
Phil> int type, convert to array.
Looks good, just one little nit.
Phil> + # The _M_w member can be either an unsigned long, or an
Phil> + # array. This depends on what template type was used. If it
Saying "template type" here is a bit confusing because the
specialization is based on the size. Just change "type" to
"specialization" and this is ok.
thanks,
Tom