This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: python: a patch for getting target thread id from a thread object
- From: Tom Tromey <tromey at redhat dot com>
- To: Noam Yorav-Raphael <noamraph at gmail dot com>
- Cc: archer <archer at sourceware dot org>
- Date: Tue, 29 Sep 2009 12:05:12 -0600
- Subject: Re: python: a patch for getting target thread id from a thread object
- References: <b348a0850909290257i6d4ba4aue264a625f656d45f@mail.gmail.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Noam" == Noam Yorav-Raphael <noamraph@gmail.com> writes:
Noam> Here's a simple patch which adds a method for getting the target
Noam> thread id of a Thread object.
I think the idea is fine.
BTW do you have copyright papers on file? I don't remember, and I can't
easily look... if not we have to do that before we can accept
non-trivial patches.
Noam> + { "get_target_id", thpy_get_target_id, METH_NOARGS,
Noam> + "get_target_id () -> str\n\
Noam> +Return the target ID of the thread." },
We went through and remove the "get_" prefixes everywhere a while back.
Also, I think this should be an attribute (see thread_object_getset), as
that is more consistent with our current API decisions.
Finally, this patch needs an update to doc/gdb.texinfo.
thanks,
Tom