This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: [PATCH] [python] Add gdb.value_history_count()
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Matt McCormick <matt at mmmccormick dot com>
- Cc: archer at sourceware dot org
- Date: Tue, 05 Jan 2010 14:50:53 +0000
- Subject: Re: [PATCH] [python] Add gdb.value_history_count()
- References: <1262192902-11770-1-git-send-email-matt@mmmccormick.com> <1262193413-14509-1-git-send-email-matt@mmmccormick.com>
On 12/30/2009 05:16 PM, Matt McCormick wrote:
Looks good. As this is Tom's branch he will have to note whether it
can be checked in or not. Some small nits:
> gdb/doc/ChangeLog
>
> 2009-30-12 Matt McCormick <matt@mmmccormick.com>
>
> * doc/gdb.texinfo (Basic Python): Document gdb.value_history_count.
As there is a ChangeLog in the doc/ directory, the paths should be
relative to the ChangeLog. So in this case, the doc/ prefix is not
necessary.
> gdb/testsuite/ChangeLog
>
> 2009-30-12 Matt McCormick <matt@mmmccormick.com>
>
> * testsuite/gdb.python/py-value.exp (test_value_history_count): Test
> gdb.value_history_count.
Same here with testsuite/.
> +@findex gdb.value_history_count
> +@defun value_history_count
> +Return an int corresponding to the number of entries in the value history
> +(@pxref{Value History}).
> +@end defun
Missing period at the end of that sentence.
>
> +/* This returns the number of entries in the value history. */
> +
> +int get_value_history_count();
> +
Need a space before the '('.
And git diff --check reports a rogue whitespace ;)
git diff --check
gdb/testsuite/gdb.python/py-value.exp:277: trailing whitespace.
Cheers!
Phil