Re: Patch for pascal-dynamic arrays

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Mon, 12 Apr 2010 13:25:02 +0200, Joost van der Sluis wrote:
> I have a new patch now that doesn't cause any regressions on my system,

on Fedora 12 for x86_64-m32 and native i386 (but not for x86_64 native 64bit):
-PASS: gdb.base/store.exp: var struct 4 u; print old u, expecting {s = \{0, 0, 0, 0}}
+FAIL: gdb.base/store.exp: var struct 4 u; print old u, expecting {s = \{0, 0, 0, 0}}
-PASS: gdb.base/store.exp: up struct 4 u; print old u, expecting {s = \{0, 0, 0, 0}}
+FAIL: gdb.base/store.exp: up struct 4 u; print old u, expecting {s = \{0, 0, 0, 0}}

Therefore if you have x86_64 native system reproducible by:
	cd gdb/testsuite; make site.exp; runtest --target_board unix/-m32 gdb.base/store.exp 


> Any comments, improvements, suggestions?

I have to admit I do not fell so comfortable with the part:

@@ -1045,8 +1045,8 @@ get_array_bounds (struct type *type, long *low_bound, long *high_bound)
 
   if (TYPE_CODE (index) == TYPE_CODE_RANGE)
     {
-      low = TYPE_LOW_BOUND (index);
-      high = TYPE_HIGH_BOUND (index);
+      low = value_lower_bound (type);
+      high = value_upper_bound (type);
     }

as it converts the state pre-check_typedef-ed evaluation to a dynamic one.

Going to try some alternative adjustment of this part.


Thanks,
Jan