This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
RE: Re C4x patch
- To: "'Nick Clifton'" <nickc at cygnus dot com>, ian at zembu dot com
- Subject: RE: Re C4x patch
- From: Greg Smart <GSmart at tennyson dot com dot au>
- Date: Wed, 29 Dec 1999 10:20:44 +1100
- Cc: joel dot sherrill at OARcorp dot com, Greg Smart <GSmart at tennyson dot com dot au>, m dot hayes at elec dot canterbury dot ac dot nz, binutils at sourceware dot cygnus dot com
hi Nick,
I would prefer that the patch I made against binutils-2.9.1 is
not used to patch against the CVS tree. When I originally created a
patch against the CVS tree in June, I uncovered lots of little issues
like the ones you have mentioned, and so I have fixed a lot of these
problems already. As Ian mentioned, the main concern is that I
haven't adequately ensured that I don't break other ports. Your
help here is greatly appreciated. :)
I have generated a patch against CVS@24-dec-1999, but I'm having
a problem in that gas core dumps. I am planning to send this to you
as soon as I get this sorted out, as well as addressing your other
comments.
I have also broken the patch up into 2 patches. The first patch contains
only new files, so is guaranteed not to break any existing code, and the
second patch is all the modifications to existing code. If you want, I can
send you the first patch to start the review process.
cheers
Greg
> -----Original Message-----
> From: Nick Clifton [SMTP:nickc@cygnus.com]
> Sent: Tuesday, December 28, 1999 6:19 AM
> To: ian@zembu.com
> Cc: joel.sherrill@OARcorp.com; GSmart@tennyson.com.au;
> m.hayes@elec.canterbury.ac.nz; binutils@sourceware.cygnus.com
> Subject: Re: Re C4x patch
>
> Hi Ian,
>
> : Nick, as you know, please be extremely careful about any patches to
> : any files which are not specific to the C4x.
>
> Just to set people's minds at rest I have not actually checked *any*
> of Joel's patch into the source tree yet. When I said "applied" in my
> comments what I meant was that I had applied his patch to my checked
> out tree in order to build a C4X target. I then generated a new patch
> based on this work and mailed it to Joel.
>
> My hope is that he will be able to check to see if this revised patch
> actually works for the C4X (since I assume that he can test it on real
> hardware, whereas I cannot) and that he will then resubmit this patch
> with whatever tweaks are needed, and with ChangeLog entries, so that
> it can be properly reviewed and accepted.
>
> Cheers
> Nick