This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A COFF patch


   Date: Mon, 19 Jul 1999 10:29:37 -0700 (PDT)
   From: hjl@varesearch.com (H.J. Lu)

   I don't know what you did to COFF. It seems that your change breaks
   "configure --enable-targets=all". This patch seems to fix it. It may
   not cover everything nor the best fix. But it is good enough for me
   to pass "make check" when I use "configure --enable-targets=all" on
   Linux/x86.

   Mon Jul 19 10:24:55 1998  H.J. Lu  (hjl@gnu.org)

	   * coffgen.c (coff_object_p): Check if we are fed with a COFF
	   file.

This patch is definitely wrong.  Nick, please don't check it in.

It is simply wrong for coff_object_p to be called with abfd->xvec set
to any bfd_target structure which has a NULL backend_data field.  We
need to understand why that is happening.  Nick added a field to
bfd_target; perhaps the problem is simply that he somehow forgot to
update one of the many structure initializations.

Ian

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]