This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch to rename SH mulu and muls instructions


Hi Ian,

: For a change like this, I would normally recommend adding the new
: forms of the instructions without replacing the old ones.  If you
: remove the old ones, then it is possible that existing working code
: may suddenly fail to assemble.  This seems a particular danger since
: you mention a corresponding gcc patch.

Easy enough to do.  What do you think of this version of the patch ?

Cheers
	Nick


Tue Sep  7 15:34:27 1999  Nick Clifton  <nickc@cygnus.com>

	* opcodes/sh-opc.h: Rename mulu to mulu.w and muls to muls.w.

Index: sh-opc.h
===================================================================
RCS file: /cvs/binutils/binutils/opcodes/sh-opc.h,v
retrieving revision 1.1.1.1
diff -p -r1.1.1.1 sh-opc.h
*** sh-opc.h	1999/05/03 07:29:00	1.1.1.1
--- sh-opc.h	1999/09/07 16:51:08
*************** sh_opcode_info sh_table[] = {
*** 309,318 ****
--- 309,320 ----
  
  /* 0000nnnn00101001 movt <REG_N>        */{"movt",{A_REG_N},{HEX_0,REG_N,HEX_2,HEX_9}},
  
+ /* 0010nnnnmmmm1111 muls.w <REG_M>,<REG_N>*/{"muls.w",{ A_REG_M,A_REG_N},{HEX_2,REG_N,REG_M,HEX_F}},
  /* 0010nnnnmmmm1111 muls <REG_M>,<REG_N>*/{"muls",{ A_REG_M,A_REG_N},{HEX_2,REG_N,REG_M,HEX_F}},
  
  /* 0000nnnnmmmm0111 mul.l <REG_M>,<REG_N>*/{"mul.l",{ A_REG_M,A_REG_N},{HEX_0,REG_N,REG_M,HEX_7}},
  
+ /* 0010nnnnmmmm1110 mulu.w <REG_M>,<REG_N>*/{"mulu.w",{ A_REG_M,A_REG_N},{HEX_2,REG_N,REG_M,HEX_E}},
  /* 0010nnnnmmmm1110 mulu <REG_M>,<REG_N>*/{"mulu",{ A_REG_M,A_REG_N},{HEX_2,REG_N,REG_M,HEX_E}},
  
  /* 0110nnnnmmmm1011 neg <REG_M>,<REG_N> */{"neg",{ A_REG_M,A_REG_N},{HEX_6,REG_N,REG_M,HEX_B}},

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]