This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: x86 gas aout emulation support
- To: Ian Lance Taylor <ian at zembu dot com>
- Subject: Re: x86 gas aout emulation support
- From: Alan Modra <alan at SPRI dot Levels dot UniSA dot Edu dot Au>
- Date: Tue, 25 Jan 2000 09:38:37 +1030 (CST)
- cc: binutils at sourceware dot cygnus dot com
On 24 Jan 2000, Ian Lance Taylor wrote:
> Date: Mon, 24 Jan 2000 11:26:32 +1030 (CST)
> From: Alan Modra <alan@SPRI.Levels.UniSA.Edu.Au>
>
> ! (&S_GET_OTHER == 0 || &S_GET_DESC == 0
>
> This usage seems somewhat awkward and error-prone.
Agreed.
>
> Suppose we instead require that any multi-capable target define these
> functions as noops? Or perhaps we can clean it up in some other
> way--calling a.out specific code from read.c like that is really
> historical baggage from when gas only supported a.out.
I think changing the test to
if (
#if defined (OBJ_AOUT) || defined (OBJ_BOUT) \
|| defined (OBJ_MAYBE_AOUT) || defined (OBJ_MAYBE_BOUT)
#ifdef BFD_ASSEMBLER
(OUTPUT_FLAVOR != bfd_target_aout_flavour
|| (S_GET_OTHER (symbolP) == 0 && S_GET_DESC (symbolP) == 0)) &&
#else
(S_GET_OTHER (symbolP) == 0 && S_GET_DESC (symbolP) == 0) &&
#endif
#endif
etc.
will do the trick. Defining as no-ops won't work where I do the same
sort of test in symbol.c