This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patch to nm allows nm to differentiate between weak functions and weak objects


Hi Thomas,

: We need to distiguish in an nm dump listing between symbols
: that are weak functions and symbols that are weak objects. nm
: only dumped weak syms without making the distinction. A new "letter"
: was added "V/v" to show weak objects...

This patch is mostly OK, but there are two problems:

  1. You need to extend the documentation (binutils.texi) to include
     the new symbols.

  2.  You need to fix the formatting of the comment describing the W
      and V symbols:

: !   if (symbol->flags & BSF_WEAK) 
: !     {
: !       /*
: ! 	W = weak function
: ! 	V = weak object
: !        */
: !     if (symbol->flags & BSF_FUNCTION)
: !       return 'W';
: !     else if (symbol->flags & BSF_OBJECT)
: ! 	return 'V';
: !     }

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]