This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: Patch: fix shell lossage in BFD_HAVE_SYS_PROCFS_TYPE_MEMBER
- To: jimb at cygnus dot com (Jim Blandy)
- Subject: Re: Patch: fix shell lossage in BFD_HAVE_SYS_PROCFS_TYPE_MEMBER
- From: "Philippe De Muyter" <phdm at macqel dot be>
- Date: Thu, 2 Mar 100 17:03:00 +0100 (CET)
- Cc: binutils at sourceware dot cygnus dot com
>
> > > > 2000-02-09 Jim Blandy <jimb@redhat.com>
> > > >
> > > > * acinclude.m4 (BFD_HAVE_SYS_PROCFS_TYPE_MEMBER): Don't forget to
> > > > put quotes around the cache variable referenc when passing it to
> > > > `test', so it'll always expand into an argument.
> > >
> > > This patch does no harm, so it is OK with me, but I don't understand
> > > why it is necessary. If this patch is necessary, there are a number
> > > of other places where a cache variable is tested without using quotes.
> > > The autoconf macros should always arrange for a cache variable to have
> > > a non-empty value; why is that not happening for you?
> >
> > I don't know. I'll figure it out, and get back to you.
>
> I can't reproduce this any more, so I withdraw this patch.
>
Did it happen because you had a cache file, but not containing this particular
variable, because either it was a new one (introduced by a new test in
configure) or either the cache file was shared by many configure-files,
and the first configure does not initialize this particular variable ?
If that can happen, I would not withdraw your patch.