This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: Patch to gas/read.c to control implicit lcomm alignment
- To: hans-peter dot nilsson at axis dot com
- Subject: Re: Patch to gas/read.c to control implicit lcomm alignment
- From: Ian Lance Taylor <ian at zembu dot com>
- Date: 10 Mar 2000 15:13:17 -0800
- CC: binutils at sourceware dot cygnus dot com
- References: <200003102310.AAA14265@ignucius.axis.se>
Date: Sat, 11 Mar 2000 00:10:18 +0100
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Sat Mar 11 00:01:39 2000 Hans-Peter Nilsson <hp@axis.se>
* read.c (s_lcomm_internal): Wrap implicit alignment in #ifndef
NO_IMPLICIT_LCOMM_ALIGNMENT.
Don't make macros negative. That makes it harder to understand how to
use them. Make it IMPLICIT_LCOMM_ALIGNMENT, and give it a default of
1.
However, in this case, I think a better fix would be a macro which
takes the size and returns the alignment. The current code could be
the default implementation of that macro.
Document new macros in gas/doc/internals.texi.
Thanks.
Ian