This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Minor dubious fix for am33 gas



  In message <ord7o75ngr.fsf@zecarneiro.lsd.ic.unicamp.br>you write:
  > --=-=-=
  > 
  > On Apr  1, 2000, Jeffrey A Law <law@cygnus.com> wrote:
  > 
  > > Though as you note, recognizing them may cause problems with older
  > > am30/mn10300 code if they used those names for in assembly code.
  > 
  > In fact, we'd already cause trouble compiling mn10300 code containing
  > symbols such as `r0'.  This patch fixes this bug.  While I was at it,
  > I cleaned up some constants so as to use #defines instead of
  > literals.  Ok to install?  Head and branch?
  > 
  > BTW, the extra register names need not be defined at all.  The code to
  > handle them is all already in place.  Adding them to the array was not
  > needed.
  > 
  > 
  > --=-=-=
  > Content-Type: text/x-patch
  > Content-Disposition: inline; filename=mn10300-clean-up.patch
  > 
  > Index: gas/ChangeLog
  > from  Alexandre Oliva  <aoliva@cygnus.com>
  > 	
  > 	* config/tc-mn10300.c (md_pseudo_table): Use constant names.
  > 	(md_begin): Likewise.
  > 	(HAVE_AM33): New macro.
  > 	(md_assemble): Use it.  Match r_regs and xr_regs only if
  > 	HAVE_AM33.
OK for the head.  I'm not sure what the branch requirements are, so I'm
going to wait for input from the release manager before approving something
for the release branch.

[I'd consider this is relatively minor problem on a relatively obscure chip,
 so I wouldn't get bent out of shape if we didn't include it in the release. ]

jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]