This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: [RFA] Fix warnings for d10v-elf
- To: Nick Clifton <nickc at cygnus dot com>
- Subject: Re: [RFA] Fix warnings for d10v-elf
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Wed, 12 Apr 2000 13:07:54 +1000
- CC: binutils at sourceware dot cygnus dot com
- Organization: Cygnus Solutions
- References: <200004101658.JAA26132@elmo.cygnus.com>
Nick Clifton wrote:
>
> Hi Andrew,
>
> : > : * config/tc-d10v.c (d10v_fix_adjustable, md_pcrel_from_section):
> : > : Change type of `fixS' argument to `struct fix'.
> : >
> : > Why is this necessary ? 'fixS' is a typedef of 'struct fix'.
> :
> : I tried that and got:
> :
> : In file included from targ-cpu.h:1,
> : from /home/scratch/SRC/src/gas/config/obj-elf.h:40,
> : from obj-format.h:1,
> : from /home/scratch/SRC/src/gas/config/te-generic.h:19,
> : from targ-env.h:1,
> : from /home/scratch/SRC/src/gas/as.h:616,
> : from /home/scratch/SRC/src/gas/app.c:29:
> : /home/scratch/SRC/src/gas/config/tc-d10v.h:60: parse error before `*'
> :
> : There is a ``struct fix;'' in as.h.
>
> That is very strange. I tried checking out and building GAS for the
> d10v using the current sources (without your patch applied) and it
> built just fine. In particular this problem should not arise because
> in gas/write.h there is the line:
Hmm, maybe I answered the wrong question. Were you asking about my
fixS->``struct fix'' as a general question or specificly for the
function definition in tc-d10v.c?
The declaration needs ``struct fix''. I changed the definition to match
the declaration for consistency.
enjoy,
Andrew