This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: A patch for http://sourceware.cygnus.com/ml/binutils/2000-04/msg00373.html
- To: Alan Modra <alan at linuxcare dot com dot au>
- Subject: Re: A patch for http://sourceware.cygnus.com/ml/binutils/2000-04/msg00373.html
- From: "H . J . Lu" <hjl at valinux dot com>
- Date: Mon, 17 Apr 2000 07:50:07 -0700
- Cc: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>,Florian Lohoff <flo at rfc822 dot org>, binutils at sourceware dot cygnus dot com,Ian Lance Taylor <ian at zembu dot com>
- References: <00041700361400.09661@enzo.bigblue.local> <Pine.LNX.4.21.0004172149320.31456-100000@front.linuxcare.com.au>
On Mon, Apr 17, 2000 at 11:45:02PM +1000, Alan Modra wrote:
> On Mon, 17 Apr 2000, Franz Sirl wrote:
>
> > Am Sun, 16 Apr 2000 schrieb H . J . Lu:
> > >The old gld${EMULATION_NAME}_place_orphan assumes it only processes
> > >SEC_ALLOC sections. When we allow ~SEC_ALLOC sections, we have to
> > >check it. This patch seems to fix
> > >
> > >http://sourceware.cygnus.com/ml/binutils/2000-04/msg00373.html
>
> I thought I had run the testsuite, but obviously not. I'll try not to be
> so lax again..
>
> > this patch solves the vmlinux relocation errors on PPC I got, but if I compile
> > the kernel with -gdwarf-2, it seems the debug sections no longer get merged now:
>
> The following patch hopefully Does The Right Thing. I've incorporated
> H.J.'s fix along with a few of my own, and I'll commit it after hearing
> back from you. (This one does pass "make check" on x86!)
>
It seems to work for me. But I did get
eelf_i386.c: In function `gldelf_i386_place_orphan':
eelf_i386.c:847: warning: `old' might be used uninitialized in this function
eelf_i386.c:850: warning: `ps' might be used uninitialized in this function
I checked they out. They seem harmless.
Thanks.
H.J.