This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: i386 gas patch: scale factor handling improvements


Hi Gavin,

: --- 2642,2654 ----
:     return 1;
:   }
:   
: ! 
: ! 
: ! 
: ! static int i386_scale_nowarn PARAMS ((char *));

Is there a reason for the extra blank lines ?



: + 	      if (is_space_char (*temp_string))
: + 		++temp_string;
: + 

Shouldn't this be a while loop, or is it defined that there can only
be one space character between the asterisk and the start of the next
operand ?

 
: Ok to commit?

I will it up to the x86 maintainer to officially approve or deny this
patch.  I have no objections.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]