This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: New members in struct format_ops in gas/obj.h used with multiformat targets
- To: hans-peter dot nilsson at axis dot com
- Subject: Re: New members in struct format_ops in gas/obj.h used with multiformat targets
- From: Nick Clifton <nickc at cygnus dot com>
- Date: Mon, 22 May 2000 10:18:05 -0700
- CC: binutils at sourceware dot cygnus dot com
Hi Hans-Peter,
: I'm not really a fan of the void-value-cast form for macro definitions for
: void function pointers used in obj-multi.h:
: (vfp ? (*vfp)() : (void) 0)
: I'd rather use:
: do { if (vfp) (*vfp)(); } while (0)
: because having void-expressions in the arms of the ? : operator seems
: brittle portabilitywise.
I agree. Feel free to change it over in any future patches.
: Ok to commit?
Yup - go ahead.
Cheers
Nick