This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: New members in struct format_ops in gas/obj.h used with multiformat targets


Hi Hans-Peter,

: I'm not really a fan of the void-value-cast form for macro definitions for
: void function pointers used in obj-multi.h:
:  (vfp ? (*vfp)() : (void) 0)
: I'd rather use:
:  do { if (vfp) (*vfp)(); } while (0)
: because having void-expressions in the arms of the ? : operator seems
: brittle portabilitywise.

I agree.  Feel free to change it over in any future patches.


: Ok to commit?

Yup - go ahead.


Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]