This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: A bad change to gas
- To: "H . J . Lu" <hjl at valinux dot com>
- Subject: Re: A bad change to gas
- From: Alan Modra <alan at linuxcare dot com dot au>
- Date: Sun, 4 Jun 2000 13:35:25 +1000 (EST)
- cc: binutils at sourceware dot cygnus dot com
On Sat, 3 Jun 2000, H . J . Lu wrote:
> The problem is `;' was the line separator by default. Many CPUs,
> including ia32, doesn't have `;' in line_separator_chars. Your change
> just breaks all those CPUs :-).
Oops, that really is a bug of the red-faced variety. Your fix isn't right
though, because some CPU's, eg. hppa, *don't* use `;' as a line separator.
I'm fixing your fix :-) for my breakage by putting back the #ifdef TC_HPPA
we originally had.
The proper fix is to go through all the gas/config/tc files and explicitly
add the `;' to line_separator_chars. I think it's worth doing things
correctly as we get to remove a target dependent #ifdef from the
supposedly target independent files.
--
Linuxcare. Support for the Revolution.