This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: A bad change to gas
- To: "H . J . Lu" <hjl at valinux dot com>
- Subject: Re: A bad change to gas
- From: Alan Modra <alan at linuxcare dot com dot au>
- Date: Sun, 4 Jun 2000 14:18:12 +1000 (EST)
- cc: binutils at sourceware dot cygnus dot com
On Sat, 3 Jun 2000, H . J . Lu wrote:
> > The proper fix is to go through all the gas/config/tc files and explicitly
> > add the `;' to line_separator_chars. I think it's worth doing things
>
> I tried it first. But I am not so convinced that it is a right way
> to go. It may break some platforms. If `;' is not a line separator on
> a platform by default, it is ok to treat it as a line separator unless
> it is for something else. In case of hppa, `;' is a comment char.
> It is set by comment_chars. It will override is_end_of_line.
Not always. Some (probably irrelevant) examples: "as -f ..." or #NO_APP
> > correctly as we get to remove a target dependent #ifdef from the
> > supposedly target independent files.
> >
>
> Could you please provide a testcase before you make any changes? I'd
> like to keep the way it is unless there is a testcase to show the
> current code is wrong.
H.J., some changes to code are to fix bugs, and a testcase is
appropriate. Other changes are for correctness of a more theoretical
sort, for elegance, and for maintainability. Any further tidying up
of is_end_of_line falls into the latter category.
Regards, Alan Modra
--
Linuxcare. Support for the Revolution.