This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [rfa] bfd_elf_sign_extend_vma()


Alan Modra wrote:

> Not quite :-)  bfd-in2.h is a generated file.  Patch bfd-in.h instead then
> run "make headers" in bfd/.

Thanks.

> > The name and return value conventions are consistent with
> > bfd_elf_get_arch_size().
> 
> Which leads to the result that non-elf returns -1, and -1 is a perfectly
> good "true" value.  Did you intend that all non-elf cases use sign
> extension?

Its fairly consistent with bfd_elf_get_addr_size() which returns the
address size or -1 on error.  If you've a better suggestion I'd be
interested?  I can't throw an error :-)

	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]