This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch for elf32-sh.c
- To: bernds at cygnus dot co dot uk, amylaar at cygnus dot co dot uk
- Subject: Re: Patch for elf32-sh.c
- From: Ian Lance Taylor <ian at zembu dot com>
- Date: 9 Aug 2000 08:27:31 -0700
- CC: binutils at sources dot redhat dot com
- References: <Pine.LNX.4.21.0008091045060.19159-100000@balti.cygnus.co.uk>
Date: Wed, 9 Aug 2000 10:47:16 +0100 (BST)
From: Bernd Schmidt <bernds@cygnus.co.uk>
This patch corrects a bug in sh_elf_reloc_loop. A value is saved by
a function for the next time it is called, but the variable used for saving
it isn't static.
My general philosophy when maintaining BFD was to make all the
functions reentrant. Therefore, no variables should be static. I
would have stored the data in the BFD somewhere.
Ian