This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] expr.c: Fix formatting.
- To: kazu at isuzu dot hxi dot com
- Subject: Re: [patch] expr.c: Fix formatting.
- From: Andrew Haley <aph at pasanda dot cygnus dot co dot uk>
- Date: 11 Aug 2000 10:29:30 -0000
- CC: binutils at sources dot redhat dot com
There is a number of wrong with this.
Also, there's an interpretation question. The standard says "write
complete sentences and capitalize the first word." I don't think that
it means you should capitalize a phrase that isn't a sentence. There
are many instances of these, so I haven't commented on them
individually.
> Index: expr.c
> ===================================================================
> RCS file: /cvs/src/src/gas/expr.c,v
> retrieving revision 1.20
> diff -u -r1.20 expr.c
> --- expr.c 2000/07/17 17:51:18 1.20
> +++ expr.c 2000/08/10 22:24:05
> @@ -223,21 +219,21 @@
> LITTLENUM_TYPE generic_bignum[SIZE_OF_LARGE_NUMBER + 6];
> FLONUM_TYPE generic_floating_point_number =
> {
> - &generic_bignum[6], /* low (JF: Was 0) */
> - &generic_bignum[SIZE_OF_LARGE_NUMBER + 6 - 1], /* high JF: (added +6) */
> - 0, /* leader */
> - 0, /* exponent */
> - 0 /* sign */
> + &generic_bignum[6], /* Low. (JF: Was 0) */
> + &generic_bignum[SIZE_OF_LARGE_NUMBER + 6 - 1], /* High. JF: (added +6) */
> + 0, /* Leader. */
> + 0, /* Exponent. */
> + 0 /* Sign. */
These comments shouldn't be capitalized; they are identifiers.
Changing the spelling of an identifier makes it a different
identifier.
> @@ -640,15 +632,15 @@
> number |= (-(number >> (TARGET_WORD_SIZE - 1))) << (TARGET_WORD_SIZE - 1);
> #endif
> expressionP->X_add_number = number;
> - input_line_pointer--; /* restore following character. */
> - } /* really just a number */
> + input_line_pointer--; /* Rstore following character. */
Spelling error.
> + } /* Really just a number. */
> }
> else
> {
> /* not a small number */
> expressionP->X_op = O_big;
> - expressionP->X_add_number = number; /* number of littlenums */
> - input_line_pointer--; /*->char following number. */
> + expressionP->X_add_number = number; /* Number of littlenums. */
> + input_line_pointer--; /* -> char following number. */
> }
> }
>
> @@ -1025,9 +1013,9 @@
> as_bad (_("Missing '%c' assumed"), c == '(' ? ')' : ']');
> }
> else
> - input_line_pointer++;
> + input_line_pointer++;
This looks wrong.
Andrew.