This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [patch] small fix for ar.c

To: Geoff Keating <geoffk at cygnus dot com>
Subject: Re: [patch] small fix for ar.c
From: Jes Sorensen <jes at linuxcare dot com>
Date: Fri, 11 Aug 2000 16:25:06 +0200
Cc: binutils at sourceware dot cygnus dot com
References: <200008102141.RAA18775@plonk.linuxcare.com><200008102336.QAA18536@localhost.cygnus.com>

>>>>> "Geoff" == Geoff Keating <geoffk@cygnus.com> writes:

>> Date: Thu, 10 Aug 2000 17:41:00 -0400 From: Jes Sorensen
>> <jes@linuxcare.com>
>> ar.c from current CVS crashes when called without arguments because
>> it tries to do a strcmp on argv[1] which is NULL.

Geoff> Oops!

Geoff> Your patch is not quite right, though.  We want to change the
Geoff> loop to:

That looks just as good or in fact better.

I just saw the problem when invoking ar without any command line
arguments. Not exactly a super important case ;-)

Thanks,
Jes

References:
- [patch] small fix for ar.c
  - From: Jes Sorensen
- Re: [patch] small fix for ar.c
  - From: Geoff Keating

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]