This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: GAS for ARM: Reject ASR/LSR/ROR with immediate of 0
- To: rearnsha at arm dot com
- Subject: Re: GAS for ARM: Reject ASR/LSR/ROR with immediate of 0
- From: Nick Clifton <nickc at redhat dot com>
- Date: Fri, 18 Aug 2000 12:28:57 -0700
- CC: scottb at netwinder dot org, Philip dot Blundell at pobox dot com, binutils at sources dot redhat dot com
Hi Richard,
: So make it an as_warn, rather than an as_tsktsk. Then the user can
: add -X to the assembly and will get an error.
Done.
: ! if (num == 0)
: ! {
: ! as_tsktsk (_("Shift of 0 ignored."));
: ! >>> shift = shift_names;
: ! assert (shift->properties->index == SHIFT_LSL);
: ! }
:
: On a point of style, I find assigning the "whole array" here confusing.
: It would be much clearer if this read
:
: shift = &shift_names[0];
I kind of liked it :-) Oh well, anything for clarity and ease of
comprehension.
Done.
Cheers
Nick