This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Changes to gas/write.c and others break the ia32 assembler
On Aug 23, 2000, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Aug 23, 2000, "H . J . Lu" <hjl@lucon.org> wrote:
>>> How did it work without it, in write.c?
>> Because write.c includes config/obj-elf.h, which defines OBJ_ELF,
>> after config/tc-i386.h. OBJ_MAYBE_ELF may be defined in config.h,
>> which is a generated file.
> I see. Thanks, I'll fix that.
i386 was the only affected port that referred OBJ_MAYBE_ELF in its
configuration file, so it's the only one I'm modifying. With this
patch, the build with the --enable-targets you reported before passes
all ld tests. Ok to install?
Index: gas/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* config/tc-i386.h <OBJ_MAYBE_ELF, OBJ_MAYBE_COFF>
(TC_FIX_ADJUSTABLE): Define.
Index: gas/config/tc-i386.h
===================================================================
RCS file: /cvs/src/src/gas/config/tc-i386.h,v
retrieving revision 1.14
diff -u -p -r1.14 tc-i386.h
--- gas/config/tc-i386.h 2000/08/23 11:19:20 1.14
+++ gas/config/tc-i386.h 2000/08/23 18:50:00
@@ -41,7 +41,7 @@ struct fix;
#define tc_fix_adjustable(X) tc_i386_fix_adjustable(X)
extern int tc_i386_fix_adjustable PARAMS ((struct fix *));
-#if (defined (OBJ_ELF) || defined (OBJ_COFF)) && !defined (TE_PE)
+#if (defined (OBJ_MAYBE_ELF) || defined (OBJ_ELF) || defined (OBJ_MAYBE_COFF) || defined (OBJ_COFF)) && !defined (TE_PE)
/* This arranges for gas/write.c to not apply a relocation if
tc_fix_adjustable() says it is not adjustable. */
#define TC_FIX_ADJUSTABLE(fixP) tc_fix_adjustable (fixP)
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me