This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

A patch for ltmain.sh


The new glibc will issue a warning when you link in mktemp.o. It causes
the false failure with "make check":

/home/redhat/vacdrom/binutils/BUILD/binutils-2.10.0.29/binutils/strip-new tmpdir/testprog.o
Executing on host: /home/redhat/vacdrom/binutils/BUILD/binutils-2.10.0.29/binutils/strip-new tmpdir/testprog.o   (timeout = 300)
bucomm.o: In function `make_tempname':^M
bucomm.o(.text+0x3c3): the use of `mktemp' is dangerous, better use `mkstemp'^M
bucomm.o: In function `make_tempname':
bucomm.o(.text+0x3c3): the use of `mktemp' is dangerous, better use `mkstemp'

FAIL: strip

I think we can ignore the messages from relink. If there is a real
problem, we will see in the normal link. I can image the messages from
relink may be useful for libtool developers. But I certainly don't
want to see them in "make check". Here is a patch.


-- 
H.J. Lu (hjl@gnu.org)
--
2000-10-08  H.J. Lu <hjl@gnu.org>

	* ltmain.sh (relink_command): Redirect all messages to
	/dev/null to avoid unecessary linker messages for "make check".

Index: ltmain.sh
===================================================================
RCS file: /work/cvs/gnu/binutils/ltmain.sh,v
retrieving revision 1.10
diff -u -p -r1.10 ltmain.sh
--- ltmain.sh	2000/09/30 16:04:05	1.10
+++ ltmain.sh	2000/10/08 17:38:47
@@ -3660,7 +3660,7 @@ sed_quote_subst='$sed_quote_subst'
 # if CDPATH is set.
 if test \"\${CDPATH+set}\" = set; then CDPATH=:; export CDPATH; fi
 
-relink_command=\"$relink_command\"
+relink_command=\"$relink_command > /dev/null 2>&1\"
 
 # This environment variable determines our operation mode.
 if test \"\$libtool_install_magic\" = \"$magic\"; then

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]