Re: [patch] pe-dll.c: Fix formatting (another one!)

[DJ Delorie <dj at delorie dot com>]

> > -	  /* Warning: the allocated symbols are remembered in BFD and reused
> > -	     later, so don't free them! */
> > -	  /* free (symbols); */
> 
> You may as well delete the "free (symbols)" completely.  Leaving code
> commented out, or inside #if 0 .. #endif is really only useful if someone
> might want to enable it in the future.

Please leave the code the way I had it.  Yes, I had a good reason for
doing it that way, which the comment above it hints at.  If you read
the code preceeding that free, you'd think a free was required.  If
you put it in, you get a subtle crash much later in the linker.
Leaving the commented out code and the comment there reminds me and
future maintainers that the free may not happen there.

-} pe_details_type;
+}
+pe_details_type;

I'm not too keen on these types of reformatting.  It makes it a lot
harder to search for structure definitions, and interferes with
searching for function definitions.  Also, I couldn't find the
reference in the GNU standards document where this type of formatting
is called for.  Could you please limit your changes to those that are
required by the spec, and reference the part of the spec you're making
the source conform to?