This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: bfd/section.c patch
- To: Tom Rix <trix at redhat dot com>
- Subject: Re: bfd/section.c patch
- From: Alan Modra <alan at linuxcare dot com dot au>
- Date: Wed, 11 Oct 2000 02:27:40 +1100 (EST)
- cc: binutils at sources dot redhat dot com, geoffk at cygnus dot com
On Tue, 10 Oct 2000, Tom Rix wrote:
> This is a trivial patch to the bfd/section.c file.
Um, don't ever treat bfd_release as trivial. bfd_release calls
libiberty/objalloc.c:objalloc_free_block, which releases all more recently
alloc'd blocks as well as the passed block. You really need to carefully
check all functions called between the bfd_alloc and bfd_release, as
otherwise you might end up with dangling references. After doing some
checking, I think it's OK here though.
> ! bfd_release(abfd, newsect);
There should be a space between the function name and open parenthesis.
Also, please submit ChangeLog entries as plain text rather than diffs.
These rarely apply cleanly.
Thanks, committed.
Alan Modra
--
Linuxcare. Support for the Revolution.