This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: luciano gemme
- To: ishitawa at yahoo dot com
- Subject: Re: luciano gemme
- From: Nick Clifton <nickc at redhat dot com>
- Date: Fri, 13 Oct 2000 13:47:25 -0700
- CC: binutils at sourceware dot cygnus dot com
- References: <003801c03494$8abcb140$b394abd4@desktop>
Hi Gemme,
: I submit the change for objcopy utility as previously declared in a
: previous mail.
: I've already sent the copyright form properly signed
I am currently waiting to here from the FSF lawyers that the copyright
assignment has gone through. Once it has I will consider applying
your patch.
Please note however, that there are a couple of problems with your
patch:
* You did not include any ChangeLog entries for the files that you
have modified. These really should be included.
* You have added documentation for the new command line switches to
objcopy.1 (good) but you forgot to also add the documentation to
binutils.texi (bad).
* You have added a new command line switch --srec-forceS3 to only
allow the generation of S3 srecords. Really this switch should
take an argument of the type of srecord that should be forced, ie
--srec-force={1|2|3}.
Cheers
Nick