This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] MIPS32 is a real ISA, and MIPS ISA/CPU name/constant cleanup.


Chris G. Demetriou writes:
 > cgd@sibyte.com (Chris G. Demetriou) writes:
 > > Oh, hmm.  I'd basically been sorting by file, on the theory that
 > > obviously the whole thing was in some sense "related."  8-)  (I've
 > > never really read the GNU coding standards, i've tried to pick up what
 > > I can from the sources and what I see here.)
 > > 
 > > 
 > > So, it should go something like:
 > > 
 > > 	* file1 (fn1, fn2): Make it sing.
 > > 	(fn3): Supply two different song choices.
 > > 	* file2, file3: New files, containing audio samples
 > > 
 > > 	* file1 (fn1, fn2): Make it dance.
 > > 	* file4 (fn3): Likewise.
 > > 	(fn4): Add dance steps.

Yep.  (IMO of course, but I believe it follows the GNU standards).

 > And, I suppose, that begs the question (if the above style is somewhat
 > correct), should I reformat the ChangeLogs to fit and resubmit my
 > patch with them (or is it good enough as is but best corrected going
 > forward)?

Nick's call.  I'd just ask Nick tweak them this time.
There's some manual effort to applying changelog entries
anyway, the additional effort is minimal.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]