Re: to XFAIL or not to XFAIL

[cgd at sibyte dot com (Chris G. Demetriou)]

Nick Clifton <nickc@redhat.com> writes:
> : BTW, relating to this one, I noticed some stuff in the gas tests that
> : might make it possible to reasonable fix this up so it'll work on
> : mips-elf too, and re-enable it.
> 
> That would be nice - how would the fix work ?

gas/testsuite/lib/gas-defs.exp (regexp_diff) had code added in rev 1.3
to make comment lines also allow for extra lines in the output being
compared against.

Basically, move that fix over into the binutils regexp_diff, and
adjust the testcase to add comment lines in the appropriate places and
get away from hard coding the section numbers in the readelf output.

I noticed this when plinking at the gas/elf/section[01].d changes i
submitted yesterday.  That mod to gas regexp_diff had been added to
allow those tests to cope with additional output due to sections
present only on mips, and the application to the readelf problem
seemed obvious.



chris