This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch to remove confusing warning generated by objcopy -I binary
- To: hiller at redhat dot com
- Subject: Re: Patch to remove confusing warning generated by objcopy -I binary
- From: Nick Clifton <nickc at redhat dot com>
- Date: Wed, 1 Nov 2000 17:21:45 -0800
- CC: binutils at sources dot redhat dot com
Hi Matthew,
: 2000-11-01 Matthew Hiller <hiller@redhat.com>
:
: * binutils/objcopy.c (copy_object): Output "output file cannot
: represent architecture" warning only when appropriate.
:
: * bfd/binary.c: Adjusted opening comment.
Approved.
: --- 772,789 ----
: (bfd_get_file_flags (ibfd)
: & bfd_applicable_file_flags (obfd))))
: RETURN_NONFATAL (bfd_get_filename (ibfd));
: +
:
Why add this extra blank line ?
: ! /* Copy architecture of input file to output file. Output a warning
: ! if this can't be done, but don't issue the warning if the input
: ! format does not have an architecture associated with it (e.g.,
: ! the "binary" format.) */
Formatting - comments should have two space after the end of the final
sentence and before the closing */.
Cheers
Nick