This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix for parallel_ok in d10v assembler


Hi Matt,

: 	Not precisely. It's perfectly okay for brf0t.s to be in a
: sequenced packed instruction, which ALONE doesn't allow for. e.g., in the
: testcase that I'm working with,
: 
: brf0t.s 14 <func_a+0x4> ->      mv      r0, r2
: 
: 	It's just not okay for it to appear in a in a parallel packed
: instruction, e.g.,
: 
: brf0t.s 14 <func_a+0x4> ||      mv      r0, r2
: 
: 	Without the check for the BRANCH attribute, when the assembler is
: run with -O, it will wrongly decide that the sequence can be put in a
: parallel packed instruction rather than a sequential.

Ah, OK - is it ever permissible for a branch instruction to occur in
parallel with another instruction ?  If not, then your patch is fine,
although the comment (above the patched lines of code) ought to be
updated.

Let me know and I will check the patch in.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]