This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PATCH: gas/config/tc-hppa.c: CHECK_FIELD typos.


As yet untested, changes to correct typos in the CHECK_FIELD values.
There is another candidate in pa_ip, but excluding zero seems possible.


            /* Handle a 9 bit immediate at 28.  */
            case '$':
              num = pa_get_absolute_expression (&the_insn, &s);
              if (strict && the_insn.exp.X_op != O_constant)
                break;
              s = expr_end;
              CHECK_FIELD (num, 511, 1, strict);
              INSERT_FIELD_AND_CONTINUE (opcode, num, 3);



2000-12-13  Rodney Brown  <RodneyBrown@mynd.com>

	* config/tc-hppa.c (pa_ip): Correct CHECK_FIELD typo.
	(md_apply_fix): Correct possible CHECK_FIELD typo.

--- gas/config/tc-hppa.c.orig	Sun Dec  3 17:49:21 2000
+++ gas/config/tc-hppa.c	Wed Dec 13 19:17:16 2000
@@ -3438,13 +3438,13 @@ pa_ip (str)
 	    /* Handle a 26 bit immediate at 31.  */
 	    case 'D':
 	      num = pa_get_absolute_expression (&the_insn, &s);
 	      if (strict && the_insn.exp.X_op != O_constant)
 		break;
 	      s = expr_end;
-	      CHECK_FIELD (num, 671108864, 0, strict);
+	      CHECK_FIELD (num, 67108863, 0, strict);
 	      INSERT_FIELD_AND_CONTINUE (opcode, num, 0);
 
 	    /* Handle a 3 bit SFU identifier at 25.  */
 	    case 'v':
 	      if (*s++ != ',')
 		as_bad (_("Invalid SFU identifier"));
@@ -4458,13 +4458,13 @@ md_apply_fix (fixP, valp)
 
       insn = (insn & ~ 0x1fffff) | re_assemble_21 (val);
       break;
 
       /* Handle all the opcodes with the 'i' operand type.  */
     case 11:
-      CHECK_FIELD (new_val, 1023, -1023, 0);
+      CHECK_FIELD (new_val, 1023, -1024, 0);
       val = new_val;
 
       insn = (insn & ~ 0x7ff) | low_sign_unext (val, 11);
       break;
 
       /* Handle all the opcodes with the 'w' operand type.  */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]