Re: A patch to fix COFF

[Nick Clifton <nickc at redhat dot com>]

Hi H.J.

> 2001-02-22  H.J. Lu  <hjl@gnu.org>
> 
> 	* dwarf2dbg.c (dwarf2_directive_file): Call s_app_file if
> 	BFD_ASSEMBLER is not defined.

No, I think that this is wrong.  If a port is not supporting DWRAF2
debug generation then it should not have the "file" and "loc"
directives in its pseudo table.  We should not just work around the
problem in the port, which I feel is what this patch is doing.

Instead, why not just fix the SH port like this:

What do you think ?

Cheers
        Nick


Index: gas/config/tc-sh.c
===================================================================
RCS file: /cvs/src//src/gas/config/tc-sh.c,v
retrieving revision 1.34
diff -p -r1.34 tc-sh.c
*** tc-sh.c	2001/02/09 18:21:42	1.34
--- tc-sh.c	2001/02/23 19:31:39
*************** const pseudo_typeS md_pseudo_table[] =
*** 97,104 ****
--- 97,106 ----
    {"2byte", s_uacons, 2},
    {"4byte", s_uacons, 4},
    {"8byte", s_uacons, 8},
+ #ifdef BFD_ASSEMBLER
    {"file", dwarf2_directive_file, 0 },
    {"loc", dwarf2_directive_loc, 0 },
+ #endif
    {0, 0, 0}
  };