This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Bad patch for gas
- To: amodra at one dot net dot au
- Subject: Bad patch for gas
- From: "H . J . Lu" <hjl at lucon dot org>
- Date: Wed, 23 May 2001 15:01:44 -0700
- Cc: binutils at sourceware dot cygnus dot com
I am having problems with this
http://sources.redhat.com/ml/binutils/2001-05/msg00349.html
Alan, your changes break the logic of finalize_syms:
- /* Expressions aren't really symbols, so don't finalize their values
- until relaxation is complete. */
- if (final_seg == expr_section && finalize != 2)
- finalize = 0;
-/* Used to control final evaluation of expressions that are more
- complex than symbol + constant. 1 means set final value for simple
- expressions, 2 means set final value for more complex expressions. */
-int finalize_syms = 1;
+/* Used to control final evaluation of expressions. */
+int finalize_syms = 0;
/* Relaxation has completed. Freeze all syms. */
- finalize_syms = 2;
+ finalize_syms = 1;
resolve_symbol_value used to be able to temporarily change finalize.
Now, finalize is almost always 0 in resolve_symbol_value. I will see
if I can fix it without reverting the whole patch.
H.J.