This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] new option for objcopy: --keep-global-symbol
- To: hhonda at kobe-catv dot ne dot jp
- Subject: Re: [PATCH] new option for objcopy: --keep-global-symbol
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- Date: Wed, 30 May 2001 12:52:07 +0100 (BST)
- Cc: binutils at sources dot redhat dot com
- References: <200105191446.XAA06133@ns01.kobe-catv.ne.jp>
Hi Honda,
Well several people wrote in to support your idea, and nobody
complained, so I have gone ahead and applied your patch to the
sources. In fact, being the nice kind of chap that I am, I also
applied the patch to the 2.11 branch, so that when that is released
in will be in there too.
I made two changes to your patch. Firstly I created an entry in the
NEWS file mentioning this new feature. Secondly I changed the code
inside add_specified_symbols() so that it could cope with lines that
are terminated by \r\n, so that it will work under Windows(tm). I
also added the ability to use '#' as the start of a line comment,
because it was simple to do, and it is always a good idea to be
able to add comments to files.
So, thanks very much for submitting this patch, and I am sorry that
it took so long for it to be accepted, but it got through in the end.
Cheers
Nick