This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Binutuls is broken now.


> Date: Mon, 18 Jun 2001 18:22:16 -0700
> From: "H . J . Lu" <hjl@lucon.org>

> On Tue, Jun 19, 2001 at 03:13:18AM +0200, Hans-Peter Nilsson wrote:
> > > Date: Mon, 18 Jun 2001 18:10:32 -0700
> > > From: "H . J . Lu" <hjl@lucon.org>

> > > Given what we know, if my patch is not acceptable to everyone, may I
> 			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > suggest we revert the patch:

> > > We can find some better ways to deal with it later.
> > 
> > I disagree.  That would *again* SEGV as I described when the
> > patch was submitted.  I think your follow-up-patch would be much
> > better.
> 
> Please re-read my email. I wanted to check it in under the obvious
> fix rule. But you were against it.

Yes, because I wasn't convinced at that time that it didn't let
something undefined pass through to cause SEGV:s or worse.

> Please state clearly how you
> want to fix the problem.

I want to fix it by not allowing -r except in cases we know
work, as does the presented patch.  Clear enough?

Allowing -r for files in formats that *can have* but don't
happen to have relocations in a specific file is a tad
confusing; things would fail for arches that happened to have
relocations in a particular object-file.

> I really don't care how you fix it as long
> as the binary input is allowed again.

Pity.  You should care how "fixes" are done.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]