This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] basename buffer gets spammed in `ld'


On Thu, Jul 12, 2001 at 11:59:27AM -0700, David O'Brien wrote:
> On Thu, Jul 12, 2001 at 11:57:53AM -0700, David O'Brien wrote:
> > would still be needed.  My read and test cases showed the patch was fine
> > (with no test regression for i386-known-freebsd4.3.  Since all the other

It doesn't mean much.

> > basename() calls needed to be wrapped with xstrdup it appeared to me this
> > basename() call was wrapped in xstrdup for the same reason.
> 

I don't like such kind of change. Unless it is broken, don't fix
it :-).


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]