This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] pei386 dll: auto-import patch



>  > Sorry, can't use snprintf.
> 
> Why not?

Not all systems have it.  Think "cross compilers".

> Like this?  ('course, you have to #include <math.h> for the ceil 
> function.  Perhaps multiples of 128 or 256 would be better...bit 
> shifting and masking is easy -- but not really portable...)

Hmmm... You can avoid float math if you use a power of two:

	size = (size + 127) & ~127;

> FWIW, all of my changes so far (including this one) compile at least. 
> :-)  I'll test actual operation <yawn> tomorrow.  (The version I 
> reported at 11:26EDT 1Aug01, and for which I put binaries on my website 
> at 1:07EDT 2Aug01, has been minimally tested in operation.  It's just 
> these most recent nit-picky changes that haven't been tested beyond "it 
> builds"...)

Understood.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]