This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] pei386 dll: auto-import patch


(lots of stuff snipped):
Charles Wilson wrote:

> DJ Delorie wrote:
> 
>> +         /* If we haven't found very symbol, let's look for its
>> +            import thunk */
>>
>> Might want to check the text of this - found very symbol?
> 
> Corrected grammar.
> 
>> Otherwise, approved.  Please run a "make check" for gas/ld/binutils 
>> (cygwin+linux
>> preferred) before and after applying, to make sure it doesn't break
>> anything subtle.  Thanks!

 >

>> Also don't forget to change the dates in the ChangeLog ;-)
> 
> Done. Changelog split into two files: Changelog-bfd should go in 
> bfd/ChangeLog, Changelog-ld should go in ld/ChangeLog
> 
>>>   make data_import_dll static?
>>>     No, used in both pe.em and pe-dll.c
>>>     I suppose we could rename it pe_data_import_dll.
>>>
>>
>> If you wish to rename it, consider that approved as well.
> 
> data_import_dll renamed to pe_data_import_dll.


Committed patch with modifications described above.

--Chuck




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]