Re: [PATCH] Fix check for 64bit support in MIPS gas

["H . J . Lu" <hjl at lucon dot org>]

On Thu, Aug 16, 2001 at 12:53:22PM +0200, Thiemo Seufer wrote:
> H . J . Lu wrote:
> [snip]
> > > 2001-08-16  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
> > > 
> > > 	/gas/ChangeLog
> > > 	* config/tc-mips.c (md_parse_option): Add recognition of
> > > 	elf64-tradlittlemips as 64bit-support. Ifdef the
> > 
> > What did you mean by that? What did you add?
> 
> I added an check
>     strcmp (*l, "elf64-tradlittlemips") == 0)
> for the arch string in the option parsing code for "-64" which was
> obviously forgotten there.

Here is what I have

    case OPTION_64:
      {
        const char **list, **l;

        list = bfd_target_list ();
        for (l = list; *l != NULL; l++)
          if (strcmp (*l, "elf64-bigmips") == 0
              || strcmp (*l, "elf64-littlemips") == 0
              || strcmp (*l, "elf64-tradbigmips") == 0
              || strcmp (*l, "elf64-tradlittlemips") == 0)
            break;
        if (*l == NULL)
          as_fatal (_("No compiled in support for 64 bit object file format"));
        free (list);
        mips_64 = 1; 
      }
      break;  

There is

|| strcmp (*l, "elf64-tradlittlemips") == 0)

Did I miss something?


H.J.