This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Fix warnings in pe targets
- To: binutils at sources dot redhat dot com
- Subject: Fix warnings in pe targets
- From: Andreas Jaeger <aj at suse dot de>
- Date: Fri, 31 Aug 2001 10:11:20 +0200
The appended patch fixes a number of warnings and one bug I noticed
after having proper prototypes for the pe targets.
Ok to commmit?
Andreas
2001-08-31 Andreas Jaeger <aj@suse.de>
* emultempl/pe.em: Add missing prototypes.
(gld_${EMULATION_NAME}_after_open): Remove extra args to
pe_find_data_imports.
(pr_sym): Add unused attribute.
============================================================
Index: ld/emultempl/pe.em
--- ld/emultempl/pe.em 2001/08/20 02:14:50 1.49
+++ ld/emultempl/pe.em 2001/08/31 08:11:08
@@ -117,7 +117,29 @@
static void gld_${EMULATION_NAME}_finish PARAMS ((void));
static boolean gld_${EMULATION_NAME}_open_dynamic_archive
PARAMS ((const char *, search_dirs_type *, lang_input_statement_type *));
+static void gld_${EMULATION_NAME}_list_options PARAMS ((FILE *));
+static void set_pe_name PARAMS ((char *, long));
+static void set_pe_subsystem PARAMS ((void));
+static void set_pe_value PARAMS ((char *));
+static void set_pe_stack_heap PARAMS ((char *, char *));
+#ifdef DLL_SUPPORT
+static boolean pe_undef_cdecl_match
+ PARAMS ((struct bfd_link_hash_entry *, PTR));
+static void pe_fixup_stdcalls PARAMS ((void));
+static int make_import_fixup PARAMS ((arelent *));
+static void pe_find_data_imports PARAMS ((void));
+#endif
+
+static boolean pr_sym PARAMS ((struct bfd_hash_entry *, PTR string));
+static boolean gld_${EMULATION_NAME}_unrecognized_file
+ PARAMS ((lang_input_statement_type *));
+static boolean gld_${EMULATION_NAME}_recognized_file
+ PARAMS ((lang_input_statement_type *));
+static int gld_${EMULATION_NAME}_find_potential_libraries
+ PARAMS ((char *, lang_input_statement_type *));
+
+
static struct internal_extra_pe_aouthdr pe;
static int dll;
static int support_old_code = 0;
@@ -907,7 +929,7 @@
static boolean
pr_sym (h, string)
struct bfd_hash_entry *h;
- PTR string;
+ PTR string ATTRIBUTE_UNUSED;
{
if (pe_dll_extra_pe_debug)
{
@@ -951,7 +973,7 @@
if (pe_enable_stdcall_fixup) /* -1=warn or 1=disable */
pe_fixup_stdcalls ();
- pe_find_data_imports (output_bfd, &link_info);
+ pe_find_data_imports ();
pe_process_import_defs(output_bfd, &link_info);
if (link_info.shared)
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj