This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Fix distinction of 32/64bit addresses in MIPS gas


Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> writes:
> cgd@broadcom.com wrote:
> [snip]
> > yes, i know that the pointer is going to be constrainted to being a
> > sign-extended 32-bit value, but neither the compiler or any assembly
> > code that uses it needs to know that (or should).  As far as they're
> > concerned, pointers are 64-bit values and they're loaded with ld, etc.
> 
> I see. Btw, my patch actually doesn't change this behaviour, the
> HAVE_32BIT_ADDRESSES macro cares about macro expansion, so it
> changes an address load via immediates from a "lui; daddiu" sequence
> to "lui; addiu", this makes no difference. An "ld" isn't changed.

But HAVE_32BIT_ADDRESSES controls all the address calcuations done by
macros, not just those that are guaranteed to be 32-bit values.  To take
one example, if "foo" is in .sdata, won't:

	la $4,foo

use

	addiu $4,$gp,foo

after your patch?  Is $gp guaranteed to be a 32-bit value when 64-bit
pointers are being used?

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]