This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch to ld/pe-dll.c: Use explicit lookup for filering excluded objects



> A re-revised patch : Why not use a simple array for autofilter_liblist as
> well.

Please note whatever testing you've done for your patch when you
submit it.

> +         Don't export anything from system libs.  */
> +      if (abfd && abfd->my_archive &&
> +          (p=lbasename (abfd->my_archive->filename)))
> +	for (i =0; i < af_liblist_len; i++)
> +  	 if ( strstr (p, autofilter_liblist[i]))

If we're using lbasename, shouldn't we use strncmp instead of strstr?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]