This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

mips option parsing behaviour changed accidentally?


Thiemo,

I note that your change on 2001-10-03 to tc-mips.c (rev 1.78 of that
file) seems to have had the effect of making the handling in
md_parse_option for:

	OPTION_GP32
	OPTION_GP64
	OPTION_FP32
	OPTION_MABI

ELF-specific.  These options used to be supported on non-ELF systems.

I believe this change was accidental for two reasons:

	(1) there was no mention of it in the ChangeLog, and

	(2) the entries in the option table for those options weren't
	made ELF-specific.

(I was looking at the mips-ecoff test failures again, as promised in a
message I sent earlier in the day, and noticed that while the -mgp32,
etc. tests used to fail to assemble because of use of pseudo-ops
unsupported by the mips-ecoff assembler, now they bail out silently
because of a bad option.  They don't, however, print out an error
message which got me tracing down why _that_ was going wrong,
etc... 8-)


Anyway, so, was that change intentional, or is the patch below in order?

(If it was intentional, you should make a patch to the rest of the
options, and make sure that the tests which use those options aren't
even attempted for e.g. ECOFF.  However, I really don't think that's
correct...)


thanks,

chris
==
2001-10-17  Chris Demetriou  <cgd@broadcom.com>

	* config/tc-mips.c (md_parse_option): Revert change from
	2001-10-03 which accidentally made the -mgp32, -mgp64, -mfp32,
	and -mabi options ELF-specific.

Index: tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.85
diff -u -r1.85 tc-mips.c
--- tc-mips.c	2001/10/17 05:51:11	1.85
+++ tc-mips.c	2001/10/18 06:23:28
@@ -9763,6 +9763,7 @@
       if (! support_64bit_objects())
 	as_fatal (_("No compiled in support for 64 bit object file format"));
       break;
+#endif /* OBJ_ELF */
 
     case OPTION_GP32:
       mips_gp32 = 1;
@@ -9801,7 +9802,6 @@
       else
 	mips_abi = NO_ABI;
       break;
-#endif /* OBJ_ELF */
 
     case OPTION_M7000_HILO_FIX:
       mips_7000_hilo_fix = true;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]