This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] a couple of tweaks to opcodes/mips.h
- To: cgd at broadcom dot com
- Subject: Re: [PATCH] a couple of tweaks to opcodes/mips.h
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- Date: 18 Oct 2001 08:45:57 +0100
- Cc: binutils at sources dot redhat dot com
- References: <yov5lmiaxesq.fsf@highland.sibyte.com>
Hi Chris,
> 2001-10-17 Chris Demetriou <cgd@broadcom.com>
>
> * mips.h: Sort coprocessor instruction argument characters.
> (OPCODE_IS_MEMBER): Add no-op term to the expression, for
> easier source code merging.
>
> (I don't know that the latter is "OK" by the coding standards, but it
> sure is a pain to have to have to slightly tweak the OPCODE_IS_MEMBER
> changes at almost every source code merge. I'm sure others feel this
> pain. 8-)
I agree. The standards do not actually forbid this, so please go
ahead and apply it. But... please could you add a comment too, so
that somebody in the future will not be tempted to remove it on the
grounds that it is unnecessary...
Cheers
Nick