This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] a couple of tweaks to opcodes/mips.h
"Nick Clifton" <nickc@cambridge.redhat.com> writes:
> I agree. The standards do not actually forbid this, so please go
> ahead and apply it. But... please could you add a comment too, so
> that somebody in the future will not be tempted to remove it on the
> grounds that it is unnecessary...
OK. I checked in the following. (I'd done the rest of the patch
yesterday.)
(I looked for comment style like this, and found it in one or two
places so figured it was OK. I was thinking "better to have it right
near the place where people will edit, than have it have a terminal
window away." 8-)
2001-10-18 Chris Demetriou <cgd@broadcom.com>
* mips.h (OPCODE_IS_MEMBER): Add a no-op term to the end
of the expression, to make source code merging easier.
Index: mips.h
===================================================================
RCS file: /cvs/src/src/include/opcode/mips.h,v
retrieving revision 1.21
diff -u -r1.21 mips.h
--- mips.h 2001/10/18 01:50:26 1.21
+++ mips.h 2001/10/18 22:36:42
@@ -381,7 +381,8 @@
|| (cpu == CPU_R3900 && ((insn)->membership & INSN_3900) != 0) \
|| ((cpu == CPU_R10000 || cpu == CPU_R12000) \
&& ((insn)->membership & INSN_10000) != 0) \
- || (cpu == CPU_SB1 && ((insn)->membership & INSN_SB1) != 0))
+ || (cpu == CPU_SB1 && ((insn)->membership & INSN_SB1) != 0) \
+ || 0) /* Please keep this term for easier source merging. */
/* This is a list of macro expanded instructions.