This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Deleting discardable stabs
On Wed, Nov 14, 2001 at 11:36:37AM +1030, Alan Modra wrote:
> On Tue, Nov 13, 2001 at 04:12:12PM -0500, Daniel Jacobowitz wrote:
> >
> > How's it look?
>
> OK for the generic part, except for one place. I'll leave the mips
> review to the mips maintainer.
>
> > @@ -6591,6 +6594,11 @@ elf_link_input_bfd (finfo, input_bfd)
> > }
> >
> > /* Write out the modified section contents. */
> > + if (bed->elf_backend_write_section
> > + && bed->elf_backend_write_section (output_bfd, o, contents))
> > + {
> > + /* Section written out. */
> > + }
>
> Missing "else" ?
>
> > if (elf_section_data (o)->stab_info)
> > {
> > if (! (_bfd_write_section_stabs
Thanks for catching that! I think there's a string of amazing
coincidences that prevented this from dying hideously. Fixed in my
local tree.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer