This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

readelf: newline after warning


Since warnings are printed to stderr and thus separated from normal output
they should always end with newline.

Andreas.

2001-11-15  Andreas Schwab  <schwab@suse.de>

	* readelf.c: Fix warnings without terminating newline.

--- readelf.c.~1.133.~	Wed Nov 14 09:41:03 2001
+++ readelf.c	Thu Nov 15 13:29:16 2001
@@ -3566,7 +3566,7 @@
 
 	      if (ELF32_ST_TYPE (sym->st_info) != STT_SECTION)
 		{
-		  warn (_("Skipping unexpected symbol type %u"),
+		  warn (_("Skipping unexpected symbol type %u\n"),
 			ELF32_ST_TYPE (sym->st_info));
 		  continue;
 		}
@@ -3578,7 +3578,7 @@
 
 	      if (ELF64_ST_TYPE (sym->st_info) != STT_SECTION)
 		{
-		  warn (_("Skipping unexpected symbol type %u"),
+		  warn (_("Skipping unexpected symbol type %u\n"),
 			ELF64_ST_TYPE (sym->st_info));
 		  continue;
 		}
@@ -3586,7 +3586,7 @@
 
 	  if (strncmp (relname, "R_IA64_SEGREL", 13) != 0)
 	    {
-	      warn (_("Skipping unexpected relocation type %s"), relname);
+	      warn (_("Skipping unexpected relocation type %s\n"), relname);
 	      continue;
 	    }
 
@@ -5699,7 +5699,7 @@
 
   if (len == 0)
     {
-      warn (_("badly formed extended line op encountered!"));
+      warn (_("badly formed extended line op encountered!\n"));
       return bytes_read;
     }
 
@@ -7062,9 +7062,9 @@
 
     case DW_FORM_strp:
       if (debug_str == NULL)
-	warn (_("DW_FORM_strp used but no .debug_str section"));
+	warn (_("DW_FORM_strp used but no .debug_str section\n"));
       else if (uvalue >= debug_str_size)
-	warn (_("DW_FORM_strp %lx points outside of .debug_str section"),
+	warn (_("DW_FORM_strp %lx points outside of .debug_str section\n"),
 	      uvalue);
       else
         printf (" %s", debug_str + uvalue);
@@ -7075,7 +7075,7 @@
       break;
 
     default:
-      warn (_("Unrecognised form: %d"), form);
+      warn (_("Unrecognised form: %d\n"), form);
       break;
     }
 
@@ -7337,7 +7337,7 @@
 
 		  if (ELF32_ST_TYPE (sym->st_info) != STT_SECTION)
 		    {
-		      warn (_("Skipping unexpected symbol type %u"),
+		      warn (_("Skipping unexpected symbol type %u\n"),
 			    ELF32_ST_TYPE (sym->st_info));
 		      continue;
 		    }
@@ -7348,7 +7348,7 @@
 
 		  if (ELF64_ST_TYPE (sym->st_info) != STT_SECTION)
 		    {
-		      warn (_("Skipping unexpected symbol type %u"),
+		      warn (_("Skipping unexpected symbol type %u\n"),
 			    ELF64_ST_TYPE (sym->st_info));
 		      continue;
 		    }

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de				completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]